refactor: update post deployment script to more robustly fetch required resource values based on the deployment method #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harsh-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Roopan-Microsoft
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the sample data import process for the Azure deployment scripts and documentation, making it easier for users to run post-deployment steps regardless of their deployment method (
azd upor ARM/Bicep templates). The changes clarify instructions, improve user guidance, and enhance the robustness of theprocess_sample_data.shscript by supporting automatic value extraction, manual input, and better error handling.Documentation improvements:
AVMPostDeploymentGuide.mdandDeploymentGuide.mdto clearly differentiate instructions based on deployment method (azd upvs. ARM/Bicep), provide step-by-step guidance, and add notes/tips for troubleshooting and authentication propagation. [1] [2]Script enhancements for user experience and robustness:
infra/scripts/process_sample_data.shto support three modes of value extraction: fromazdenvironment, from Azure deployment outputs, or via manual user input, with clear validation and error handling for missing values. [1] [2]azdCLI installation, extract values safely, and display all resolved values before proceeding, improving transparency and reducing user error. [1] [2]DevOps workflow updates:
azure.yamlto remove the resource group argument from the sample data process command, reflecting the new script logic of auto-detecting or prompting for values. [1] [2]These changes collectively make post-deployment onboarding smoother and reduce the risk of misconfiguration for users deploying via different Azure methods.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information